Closed jma closed 6 years ago
@jma I am thinking that the probably we should put the LoanActions view only in loan_pid rest. If you extend the endpoints probably it doesn't make sense to register actions there. wdyt?
@zzacharo yes you are right. In such case we need to select the right option. I will try to solve it.
@zzacharo I think it is solved.
@jma I think that we should just hardcode it inside the build method. It's a bit confusing and actually we don't gain something from having it as _CIRCULATION_LOAN_PID_TYPE
. WDYT?
@zzacharo why using it api.py
and not in views.py
?
@jma but it's more views related not api.
@jma also can you rebase? When you do it let me know and we can merge it.
@jma I messed up your pr with another merge commit. I tried to update the branch from here. Sorry for that! Can you just rebase and push force in your pr again?
My only comment is if you want to hardcode the value loan_pid
in the build_blueprint_with_loan_actions
instead of the config. Other than that I am ok with this PR to be merged.
Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch