The purpose of this issue is to avoid exchanging emails and provide our thoughts and ideas for our solution so far and further development.
After spending some time with the existing implementation and requirements, in my opinion we are on a good phase. The solution is flexible enough to handle the cases we thought in advance, but with minor modifications can be adjusted to accommodate any further cases.
There are several user stories that can be expressed as the same query with different parameters, such as requesting available and unavailable items, or handling the same request for a patron or a librarian.
I did a pretty intensive review in the policies pull request, and after going through the pre-work, I see now what we are trying to do with the functions that try to extend policies in the utils.py. I believe we should come up with a pattern or something to provide that extendability or completely isolated under a policies.py file. Either way I believe further discussion is needed on the particular case.
All in all, it would be very nice if anybody had any ideas or thoughts that would like to put under discussion and all together take it to the next level.
The purpose of this issue is to avoid exchanging emails and provide our thoughts and ideas for our solution so far and further development.
After spending some time with the existing implementation and requirements, in my opinion we are on a good phase. The solution is flexible enough to handle the cases we thought in advance, but with minor modifications can be adjusted to accommodate any further cases.
There are several user stories that can be expressed as the same query with different parameters, such as requesting available and unavailable items, or handling the same request for a patron or a librarian.
I did a pretty intensive review in the policies pull request, and after going through the pre-work, I see now what we are trying to do with the functions that try to extend policies in the
utils.py. I believe we should come up with a pattern or something to provide that extendability or completely isolated under apolicies.pyfile. Either way I believe further discussion is needed on the particular case.All in all, it would be very nice if anybody had any ideas or thoughts that would like to put under discussion and all together take it to the next level.
Good job everybody!