search

inveniosoftware / invenio-circulation

Library circulation module for Invenio.
https://invenio-circulation.readthedocs.io
MIT License
0 stars 18 forks source link

views missing config for `CIRCULATION_LOAN_LINKS_FACTORY ` #74

Closed zzacharo closed 5 years ago

zzacharo commented 6 years ago

Here https://github.com/inveniosoftware/invenio-circulation/blob/master/invenio_circulation/views.py#L90 the loan links factory is retrieved from the config CIRCULATION_LOAN_LINKS_FACTORY but is never set to a default. Also should be changed to be able to be overridden by an external module like invenio-app-ils.

kpsherva commented 5 years ago

bug reintroduced in https://github.com/inveniosoftware/invenio-circulation/pull/82/files

zzacharo commented 5 years ago

The bug has been fixed in https://github.com/inveniosoftware/invenio-circulation/commit/8349241adedcc9e1e0b926fa8b355d62b38d73a4

zzacharo commented 5 years ago

84 completes this issue by making loan_links_factory extendable from external module.