transitions: fix ItemOnDeskToItemOnLoan checkout policy

inveniosoftware / invenio-circulation

Library circulation module for Invenio.

https://invenio-circulation.readthedocs.io

MIT License

0 stars 18 forks source link

transitions: fix ItemOnDeskToItemOnLoan checkout policy #79

Closed kpsherva closed 5 years ago

kpsherva commented 5 years ago

Allowing the manager or loan owner to checkout if the state is ITEM_AT_DESK
(closes #71)

ntarocco commented 5 years ago

I am a bit confused here. What we have discusses was to "invert" the logic for defining status from available to on_loan. Moreover, I think that permissions on a specific transition should not be implemented here, because otherwise we will have to define an action for each transition (why only checkout).

But I might have misunderstood the purpose of this PR.

ntarocco commented 5 years ago

@zzacharo can you please review again so we can fix or merge?