If `ImageMagick` isn't installed, `check-requirements` will report both failure and success - Githubissues

inveniosoftware / invenio-cli

CLI module for Invenio

https://invenio-cli.readthedocs.io

MIT License

10 stars 43 forks source link

If `ImageMagick` isn't installed, `check-requirements` will report both failure and success #291

Closed max-moser closed 2 years ago

max-moser commented 2 years ago

Package version (if known): 1.0.4

Describe the bug

The output of invenio-cli check-requirements is confusing, because it mentions both success as well as failure.

Steps to Reproduce

Install Ubuntu (e.g. on a VM)
Install most basic dependencies (but not ImageMagick... which is listed as an "extended" dependency in the docs: https://inveniordm.docs.cern.ch/install/requirements/)
Execute invenio-cli check-requirements
See error

Expected behavior

When one of the dependencies isn't found, no success message should be displayed.

Also, should ImageMagick even be checked without --development flag?

Screenshots (if applicable)