search

inveniosoftware / invenio-cli

CLI module for Invenio
https://invenio-cli.readthedocs.io
MIT License
10 stars 43 forks source link

`check-requirements`: Cairo and DejaVu Fonts #295

Open max-moser opened 2 years ago

max-moser commented 2 years ago

Is your feature request related to a problem? Please describe.

According to the InvenioRDM documentation, Cairo (e.g. libcairo2-dev) and the DejaVu fonts (e.g. fonts-dejavu) are required for a local installation. However, they are not checked by the invenio-cli check-requirements -d command. Because this does not produce immediately obvious errors, it is somewhat easy to miss them.

Describe the solution you'd like

The check-requirements command should check if the fonts and Cairo are installed.

Describe alternatives you've considered

Because checking for the installation of fonts and libraries is harder than simply checking for executables, the check-requirements command could also simply give out a reminder about these requirements (e.g. in yellow text).

avivace commented 2 years ago

I agree this should be notified in some way to the user, but IMO a persistent message printed by check-requirements will just be additional noise.

fc-list should be quite standard on both linux and macos.

max-moser commented 2 years ago

nice, i didn't know that this command existed! ldconfig -p could maybe help with libcairo, but i don't have a mac to verify it would work there

avivace commented 2 years ago

ldconfig -p

@max-moser ldconfig doesn't work on macos, I think the equivalent is update_dyld_shared_cache but requires a reboot