search

inveniosoftware / invenio-cli

CLI module for Invenio
https://invenio-cli.readthedocs.io
MIT License
10 stars 43 forks source link

Services: add 'declare queues' step to setup #345

Closed max-moser closed 1 year ago

max-moser commented 1 year ago

This is required in order for the statistics integration to work properly, because it relies on messaging via a message queue. Needs some testing.

max-moser commented 1 year ago

Seems to work well enough, the queues configured for statistics are indeed declared after invenio services setup and the statistics are working.

kpsherva commented 1 year ago

@slint @ntarocco @zzacharo should we make this step optional, called on demand or we always want to declare ?

ntarocco commented 1 year ago

I think this should be always there, mandatory step. Why optional?

kpsherva commented 1 year ago

I think this should be always there, mandatory step. Why optional?

potentially opening a discussion, wondering if we always need it, I thought there might be use cases, becuse personally I don't have one

max-moser commented 1 year ago

One thing that I just noticed (b/c I've just tested it with the master-branch InvenioRDM): This command will probably fail with older versions of InvenioRDM, because Invenio-Queues is only added as dependency in v12 :eyes: