inveniosoftware / invenio-cli

CLI module for Invenio
https://invenio-cli.readthedocs.io
MIT License
10 stars 42 forks source link

docker-compose reaches EOL in June #348

Closed wgresshoff closed 1 year ago

wgresshoff commented 1 year ago

Is your feature request related to a problem? Please describe.

docker-compose v1 reaches EOL end of june 2023. Additionally the syntax changes: instead of docker-compose new versions add compose as subcommand to docker, so it is docker compose instead.

Describe the solution you'd like

Support docker-compose if available and the newe syntax docker compose.

Describe alternatives you've considered

...

Additional context

Official announcement: https://docs.docker.com/compose/reference/

mfenner commented 1 year ago

I have been using docker compose V2 and the new syntax docker compose up for some time now and have not encountered any problems. Example at https://github.com/front-matter/docker-invenio-rdm

karkraeg commented 1 year ago

Hi @mfenner you don't use invenio-cli in the project you linked, are you?

These changes: https://github.com/karkraeg/invenio-cli/commit/8d77c22dd207ad385e50df29a44e8327526b0336 fix this issue for me, if anyone could comment on if this is really all that needs to be done it would be great. I can open a PR then as well.

mfenner commented 1 year ago

@karkraeg I used invenio-cli to build the docker images used in my Docker Compose setup.

karkraeg commented 1 year ago

@fenekku @ppanero I modified my Fork to use docker compose instead of docker-compose v1: https://github.com/inveniosoftware/invenio-cli/commit/8d77c22dd207ad385e50df29a44e8327526b0336

Would this change be of interest as a Pull Request?

docker-compose's last release was more than two years ago: https://docs.docker.com/compose/migrate/#will-i-still-be-able-to-use-compose-v1-if-i-really-want-to

This would alter the installation dependencies for invenioRDM.

fenekku commented 1 year ago

@karkraeg Yes that would be great! You can make a PR on this repo and associate it with the "PR Community" project (I will be on the lookout for it anyway if there are logistical issues).

What I am thinking is that we could either have a transition period where both are supported (recent versions of docker install a docker-compose pass-through anyway) or make a clean break especially for upcoming v12.

Clean break is probably easier and installing most recent version of docker is possible in any OS (we were initially a holdout because we didn't think our setup could support it, but it can!).

Thank you!

mfenner commented 1 year ago

Any updates on this?

karkraeg commented 1 year ago

Any updates on this?

Hi, I'm currently on vacation, I will look into whats missing to merge the PR on the 24th of July or perhaps next week, but can't promise

mfenner commented 1 year ago

Thanks for the update. Docker-compose V1 has reached EOL in June, so there is some urgency to resolve this.