inveniosoftware / invenio-cli

CLI module for Invenio
https://invenio-cli.readthedocs.io
MIT License
10 stars 43 forks source link

Switch to `docker compose` v2 #352

Closed karkraeg closed 1 year ago

karkraeg commented 1 year ago

:heart: Thank you for your contribution!

Description

As described in https://github.com/inveniosoftware/invenio-cli/issues/348 invenio-cli internally uses the deprecated version 1x of docker-compose to orchestrate containers. This forces users to install the old version alongside the newer version of docker compose. This pull request changes the underlying subcommands to use the new syntax.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
karkraeg commented 1 year ago

Hi @fenekku I can't associate it with the "PR Community" project

karkraeg commented 1 year ago

Hi, I updated my fork with your latest changes. Is there anything blocking the merging that I could help with? Tbh I somehow lost track.

fenekku commented 1 year ago

Everyone approved, tests pass and it's been out very long: I am merging. Thank you @karkraeg for all the effort, we appreciate it!