inveniosoftware / invenio-cli

CLI module for Invenio
https://invenio-cli.readthedocs.io
MIT License
10 stars 43 forks source link

Worker process should also be waited #374

Open dorinelfilip opened 2 months ago

dorinelfilip commented 2 months ago

:heart: Thank you for your contribution!

Description

Please describe briefly your pull request.

There are cases (such as the port being already in use or other fatal errors) when the server closes unexpectedly and the worker process is left running in the background with no easy option to catch it.

I changed the run command, such that it also waits for the worker. I have also add some red messages to point the die event of the server process.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.