inveniosoftware / invenio-communities

Invenio communities module.
https://invenio-communities.readthedocs.io
MIT License
5 stars 73 forks source link

members: patch pagination rendering to prevent infinite negative numbers #1137

Open Samk13 opened 3 months ago

Samk13 commented 3 months ago

:heart: Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
Samk13 commented 3 months ago

Adding showWhenOnlyOnePage from 268 seems to have no effect on this.

anikachurilova commented 2 months ago

Thank you for taking care of this! Good job 🚀 After having a look and doing a quick test, the pagination still seems to be not appearing when there are more results found than shown on the page (see the screenshot)

Screenshot 2024-06-26 at 13 25 03

Please correct me if I am checking something wrong!

Samk13 commented 2 months ago

@anikachurilova I've updated the value, which works as expected for numbers under the default pagination value. However, the issue persists with larger numbers than the default pagination value.

Update: This PR fixes the issue. In this PR I added showWhenOnlyOnePage so it will not show pagination unless needed.

Samk13 commented 2 months ago

Final result:

test-pagination-4