list locations - Githubissues

inveniosoftware / invenio-files-rest

REST API for uploading/downloading files for Invenio.

https://invenio-files-rest.readthedocs.io

MIT License

9 stars 68 forks source link

list locations #235

Closed wgresshoff closed 4 years ago

wgresshoff commented 4 years ago

In order to set a default location I need to know which are existing.

Closes https://github.com/inveniosoftware/invenio-files-rest/issues/234 Closes https://github.com/inveniosoftware/invenio-files-rest/issues/232

ppanero commented 4 years ago

As discussed IRL, the "set default" functionality will be generic so the create location will also make use of it when calling with --default

wgresshoff commented 4 years ago

Just added fix for https://github.com/inveniosoftware/invenio-files-rest/issues/232

ppanero commented 4 years ago

Slight refactoring to fixt tests. (@wgresshoff sorry I had to take out the pretty print it is a nice addition but it requires a bigger refactor along invenio).

Warning it is not backwards compatible:

CLI location command is now a group to contain its related commands create, list and set_default.
Location.get_by_name() returns now one_or_none instead of one and raising an exception if it does not exist.

ppanero commented 4 years ago

Continued in https://github.com/inveniosoftware/invenio-files-rest/pull/236