inveniosoftware / invenio-files-rest

REST API for uploading/downloading files for Invenio.
https://invenio-files-rest.readthedocs.io
MIT License
9 stars 67 forks source link

Fix: Apply `invenio-accounts` API Changes #307

Closed Samk13 closed 5 months ago

Samk13 commented 5 months ago

:heart: Thank you for your contribution!

Description

Fix failing tests

tests/conftest.py:27: in <module>
    from invenio_accounts.views import blueprint as accounts_blueprint
E   ImportError: cannot import name 'blueprint' from 'invenio_accounts.views' (/opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/invenio_accounts/views/__init__.py)

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
utnapischtim commented 5 months ago

Note: @Samk13 could you add a little bit more context to the commit message e.g. why this change fixed the CI. i would add something like: due to changes in the invenio-accounts api. with a reference to the new release. i usually don't do that either, but would be a good idea to do it. the reason is that for the reviewer it is easier to understand why this was necessary. And not to be neglected for other guys who will search for fixes of bugs in the future will understand why this change was made.