Closed mb-wali closed 6 months ago
Can we check the status of this issue?
based on this list it seems, that we have packages where we force fuzzy and packages, where this is not the case. Is this information still correct?
since this lists is already some days old, I remember, that there were new packages added, what's the status with these? The documentation mentions the fuzzy
: https://inveniordm.docs.cern.ch/develop/howtos/i18n/#configuration
Related: https://github.com/inveniosoftware/invenio-i18n/issues/99
are we sure that we need/want to force it?
I can/will try to check transifex in the upcoming weeks.
I would be happy to get some opinions/experience of the force-use
.
Maybe: @utnapischtim @rekt-hard @zzacharo
When discussed point 3. I could try to get the changes in all packages.
I think earliest end of September I can investigate that.
wrt. point 3:
header
we get the fuzzy
fuzzy
is to use python setup.py extract_messages --omit-header
fuzzy
could get in our filesfuzzy
this file will not compiled at all anymore - without any warning or error messages (others are complaining about this, too)therefore, using fuzzy
in setup.cfg
sounds the best way to go, for now:
[compile_catalog]
use-fuzzy = True
wrt. point 2:
fuzzy
: https://inveniordm.docs.cern.ch/develop/howtos/i18n/#configurationwrt. point 1:
I will try go through all packages and check for the fuzzy
and report back.
Starting with the following:
from Pipfile.lock with invenio-app-rdm "=12.0.0b2.dev35" all packages containing invenio in their name
checked | has fuzzy | okay without fuzzy
[compile_catalog]
flagbased on this:
have fuzzy:
no fuzzy but likely no problem:
no fuzzy and more likely a problem:
no fuzzy and maybe a problem:
not checked
wrt 'no fuzzy but likely no problem:'
within each repo searched for _(
, format
, gettext
, I18N
, i18next
, Trans
result:
flask-collect-invenio:
- found: python 'format'
- but no traces of translation intents
flask-kvsession:
- found _(...) in docs-folder
- but no traces of translation intents
invenio-app:
- found: 'gettext' and 'I18N' in documentation
- found: python 'format' in test_helpers
- but no traces of translation intents
invenio-assets:
- found: 'gettext' and 'I18N' in docs
- found: python 'format'
- but no traces of translation intents
invenio-base:
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-cache:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-celery:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-config:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-db:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-jsonschemas:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-logging:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-mail:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-queue:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
- .tx/config:9:# TODO: Transifex integration
invenio-records-files:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-rest:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-search:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
invenio-stats:
- found: python 'format'
- found: 'gettext' and 'I18N' in docs
- but no traces of translation intents
- .tx/config:9:# TODO: Transifex integration
Additionally found: https://github.com/inveniosoftware/cookiecutter-invenio-module/blob/6decff43538c9e317175bfed33878fe7b0843a53/%7B%7B%20cookiecutter.project_shortname%20%7D%7D/setup.cfg#L80
Conclusion:
All PRs are merged. For the moment we should be good. Let's close it. @zzacharo
In order to compile fuzzy marked strings, we need to force it. todoso we have to add this line
use-fuzzy = True
to the[compile_catalog]
section ofsetup.cfg
file.This should be added to the following modules:
Close related issue #inveniosoftware/invenio-app-rdm/issues/230