search

inveniosoftware / invenio-marc21

Nice defaults for Invenio overlays using MARC21.
https://invenio-marc21.readthedocs.io
MIT License
1 stars 20 forks source link

installation: dojson dependency bump #49

Closed tiborsimko closed 7 years ago

tiborsimko commented 7 years ago
tiborsimko commented 7 years ago

@jirikuncar @lnielsen Please note the latest commit in this PR -- 09e98fc "tests: doctext execution simplification" -- which seems to be the cleanest way how to solve the Travis CI troubles observed with the development dependencies.

Is there any particular reason why sphinx-build doctesting was done kind of "twice" in run-tests.sh in Invenio packages? (Some dependencies were removed by pytest pipinstalling before the second sphinx run, leading to Travis CI failures.) If there is no particular reason to repeat the test, then I would amend the cookiecutter in this way and update run-tests.sh etc everywhere... WDYT?

P.S. Note that @jirikuncar already amended dictdiffer in this way some time last summer.

lnielsen commented 7 years ago

@tiborsimko I don't remember any specific reason why it was like that except that pytest did the unit tests and sphinx did the doctests, but it makes fully sense to me to let pytest do everything.