inveniosoftware / invenio-oaiharvester

Invenio module for OAI-PMH metadata harvesting between repositories.
https://invenio-oaiharvester.readthedocs.io
GNU General Public License v2.0
5 stars 17 forks source link

feat: add encoding support #51

Closed jma closed 6 years ago

jma commented 6 years ago

Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

jma commented 6 years ago

isort failed on travis but works nice on my machine. Any ideas?

jacquerie commented 6 years ago

isort failed on travis but works nice on my machine. Any ideas?

Two ideas:

  1. Make sure that the version of isort matches.
  2. Make sure that you're installing exactly the same packages, as isort will report different things on where an import should be if the package is not installed.
jacquerie commented 6 years ago

It's probably 2., given that it's complaining about invenio_db, and you don't install it in the all extra (but you install it by choosing which DB backend to use, e.g. $ pip install -e .[all,sqlite3].)

jma commented 6 years ago

You are right: isort version matches, thus it is 2! But invenio-db is installed... I created a virtualenv from scratch and follows the travis steps and solved isort errors. I hope it will works!

jma commented 6 years ago

Seems ok.

jma commented 6 years ago

Any news?

jacquerie commented 6 years ago

I just noticed a question of which I happened to know the answer to, @david-caro is probably the person who should be looking at this.

david-caro commented 6 years ago

Looks good to me :), thanks for the PR!

david-caro commented 6 years ago

@jma Do you need this feature? I can do a release if that helps.

jma commented 6 years ago

@david-caro Yes, it is require for RERO DOC. Thanks for the merge.