Closed jma closed 6 years ago
isort failed on travis but works nice on my machine. Any ideas?
isort failed on travis but works nice on my machine. Any ideas?
Two ideas:
isort
matches.isort
will report different things on where an import should be if the package is not installed.It's probably 2., given that it's complaining about invenio_db
, and you don't install it in the all
extra (but you install it by choosing which DB backend to use, e.g. $ pip install -e .[all,sqlite3]
.)
You are right: isort version matches, thus it is 2!
But invenio-db
is installed...
I created a virtualenv from scratch and follows the travis steps and solved isort errors. I hope it will works!
Seems ok.
Any news?
I just noticed a question of which I happened to know the answer to, @david-caro is probably the person who should be looking at this.
Looks good to me :), thanks for the PR!
@jma Do you need this feature? I can do a release if that helps.
@david-caro Yes, it is require for RERO DOC. Thanks for the merge.
Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch