cern: replaces 'PersonID' to 'uidNumber'

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.

https://invenio-oauthclient.readthedocs.io

MIT License

6 stars 76 forks source link

cern: replaces 'PersonID' to 'uidNumber' #132

Closed pamfilos closed 7 years ago

pamfilos commented 7 years ago

closes #112

Signed-off-by: Pamfilos Fokianos pamfilosf@gmail.com

tiborsimko commented 7 years ago

@egabancho Can you check whether this change would work for CDS? Or should we make it configurable for each service?

lnielsen commented 7 years ago

[ ] Replace field with config variable that can be set to either PersonID or uidNumber
[ ] Document the difference between the two attributes.

egabancho commented 7 years ago

Replace field with config variable that can be set to either PersonID or uidNumber

Do we really need this? Using PersonID might leed to accounts having wrong access rights, among other small problems.

lnielsen commented 7 years ago

We just had a discussion about this in the Sprint kick-off. As I understood on @drjova you needed to use PersonID on CDS (as it represents the same user over multiple accounts), and CAP needs uidNumber.

If that's not the case, then I think we can just merge?

egabancho commented 7 years ago

This was de initial idea, but it might cause us a few headaches, so, uidNumber for everyone!

Once tests are passing we can :shipit: