search

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.
https://invenio-oauthclient.readthedocs.io
MIT License
6 stars 76 forks source link

Added Globus as an identity provider #158

Closed NickolausDS closed 5 years ago

NickolausDS commented 6 years ago
lnielsen commented 6 years ago

Thanks a lot for the contribution. We'll have to keep the contribution on hold for a bit because we're changing the license of Invenio from GPL to MIT. Unfortunately, discussion with our lawyers is taking longer than expected, and thus we cannot integrate code from non-CERN contributors until this has finished. I'm sorry about this.

NickolausDS commented 6 years ago

Thanks for the update, I hope the license transition goes smoothly.

slint commented 5 years ago

@NickolausDS we can merge this, though could you tell us what legal entity is the copyright holder for this code, so we can include it in the headers? Also, please check if the case is that since this code might have been written as part of an employment contract which grants your employer the copyright to all source code you write (keep in mind that this could also apply for code written outside of working hours), the copyright holder might be your employer.

rpwagner commented 5 years ago

@slint, @NickolausDS did write this as part of his employment and the copyright holder is the University of Chicago. You can see an example of our copyright headers in some of our code.

Do you need any more information or is that sufficient?

Thanks

lnielsen commented 5 years ago

@rpwagner @NickolausDS - I've rebased the PR and updated the copyright headers. Last thing before I press the merge button, could you please confirm that you license your PR under MIT License (since the old headers said GPL - which was probably just due to copy/paste)?

NickolausDS commented 5 years ago

@lnielsen Yes, confirming here to license this pull request under MIT. Thanks for switching that.

lnielsen commented 5 years ago

Merged. Thanks a lot for the contribution, and apologies for taking so long to merge.

NickolausDS commented 5 years ago

No need for an apology, I know licensing can get complex and take time to sort out all the details.

Thanks for picking this back up, your help was much appreciated!