search

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.
https://invenio-oauthclient.readthedocs.io
MIT License
6 stars 76 forks source link

test: build error on release builds #174

Closed lnielsen closed 6 years ago

lnielsen commented 6 years ago

https://travis-ci.org/inveniosoftware/invenio-oauthclient/jobs/378447672

switowski commented 6 years ago

In Flask 1.0, the exception type is changing from ValueError to TypeError: Flask.make_response() raises TypeError instead of ValueError for bad response types. The error messages have been improved to describe why the type is invalid. (#2256) - see the CHANGELOG.

@lnielsen - is it ok to bump the version of Flask to 1.0 (after I changed the exception type, tests are passing on Flask 1.0, so in my opinion we could do this)? Otherwise, I will have to pin the version of Flask to 0.12.

switowski commented 6 years ago

As discussed IRL with @lnielsen, we should support both Flask 0.11 and 1.0 (for an easier update in the future), so I will fix tests.