search

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.
https://invenio-oauthclient.readthedocs.io
MIT License
6 stars 74 forks source link

contrib: add extra cern data #179

Closed zzacharo closed 5 years ago

lnielsen commented 5 years ago

Ping @tiborsimko @pamfilos - Please check this PR as you are using the CERN OAuth contrib.

ntarocco commented 5 years ago

I think this is closing https://github.com/inveniosoftware/invenio-oauthclient/issues/178 if you want to mention it

zzacharo commented 5 years ago

@ntarocco no actually. I reverted the fix and I am gonna create a separate pr for that.

zzacharo commented 5 years ago

Ping @lnielsen @tiborsimko @pamfilos could you please check it as I need this?

lnielsen commented 5 years ago

@zzacharo I'm not a user so I can't say if this is ok or not. You're in a better position to say that than me. For sure, if we release, then we should make a new minor version since I believe this is backward incompatible?

egabancho commented 5 years ago

@zzacharo do you think we should write an upgrade recipe or something to update/invalidate all the accounts which don’t have this data? Perhaps simply force to reload it using the last updated field.

zzacharo commented 5 years ago

@egabancho yes that would be good I think. @lnielsen I don't think it will be incompatible especially if we write a recipe to update user's metadata with what @egabancho proposed..I don't know if I miss something...

ntarocco commented 5 years ago

@egabancho the refresh time is a config of 5 minutes by default (if I am not wrong), I don't think any of us changed it? At least nor videos or cern analysis preservation... @lnielsen I also don't think it is breaking since it is adding new fields and not changing existings...