inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.
https://invenio-oauthclient.readthedocs.io
MIT License
6 stars 76 forks source link

fix: add flag for auth in keycloak realm url #332

Closed rekt-hard closed 1 month ago

rekt-hard commented 1 month ago

:heart: Thank you for your contribution!

Description

closes #323

Add flag for using the auth/ part in the realm url. Newer versions of keycloak do not have an auth/ part in the realm url per default anymore. To not break existing InvenioRDM instances and oauth configurations, the flag is set to true per default.

This allows to keep all the other setup functionality and only modify the realm url if needed. Keycloak v16 support has been deprecated for quite some time now ((11 Mar 2022) according to https://endoflife.date/keycloak).

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
max-moser commented 1 month ago

thanks!

ntarocco commented 1 month ago

Needs release?

rekt-hard commented 1 month ago

Will be addressing the comment in https://github.com/inveniosoftware/invenio-oauthclient/pull/326 A release after would be great

Or two small releases. However you prefer