contrib: update github login and fix orcid disconnect

[hachreak]

• Fix github info retrieval.
• Fix orcid disconnection.
• Rely on github id instead of github primary email.
• Signup through security form.
• Prefill signup form.
• Force github registration through signup form.
• Makes signup form template configurable.

Signed-off-by: Leonardo Rossi leonardo.r@cern.ch

[coveralls]

Coverage increased (+0.03%) to 76.73% when pulling ca1dde8811d7c60ec4ea569dc90a5b2794952ac9 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[hachreak]

ping @lnielsen

[coveralls]

Coverage increased (+0.03%) to 76.73% when pulling 4645082f6f06fca2f856a256b8ee9950e8049bd3 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+0.03%) to 76.73% when pulling d6a6976563398d8a291ffa60f28bd1f6b343221b on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+0.03%) to 76.73% when pulling 4645082f6f06fca2f856a256b8ee9950e8049bd3 on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+0.03%) to 76.73% when pulling 7474b98d8b57b884bd3d1f88ce12c542071c5bbb on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+2.7%) to 79.381% when pulling 44cf2e41c14d78ef88a444cc116593d802e65eae on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+2.7%) to 79.381% when pulling 74a691a99492bb5cde06acf7c0471f8f5176025f on hachreak:fix_github into 869beb5626f83697f9180ab1c78e7bf0dbda399a on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.349% when pulling 72981a8dc1fc9fe32d94a5116e65ea8016d3d4c0 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.349% when pulling dcdeee0ef7b967100ae2c8ba90bca871db0d618d on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.349% when pulling e7891e322e3584446b1d2b4c07d5de73b32adf0c on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.349% when pulling 731b56b3a70f452061af684b384a5b0d199d7311 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.349% when pulling 731b56b3a70f452061af684b384a5b0d199d7311 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[lnielsen]

Another thing to test:

1) Create a local Invenio account with the same username as your github account, and different email. 2) Try to sign up using GitHub. This will create a conflict. Email doesn't exist in database, but username does.

Currently I don't think the sign-up form can handle this. I.e. we should probably provide the entire signup form instead of only an email address

[coveralls]

Coverage increased (+3.06%) to 85.774% when pulling c550aa0005aed2263894f9774e7cf259429843ca on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.06%) to 85.774% when pulling cae09f83d5df84c0d5d90d4fb4020e33783c4fbb on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.06%) to 85.774% when pulling 7609a277d982766b71b3d6cdb61b3302d59a21f1 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling 001f04400cc62fa1c8b84f5e5e27342430ba2cc4 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling 001f04400cc62fa1c8b84f5e5e27342430ba2cc4 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling e2e75f8d95829f4a5cfa2a8ebca55004ab14d32e on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling d5548d8f86267557d50c51a4256ed06031d9cbea on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling 3c0c732686b59c2b937fb3acbff7c23954ba5e42 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.359% when pulling 94229888feb89f31609a85c5f095f189da0f0983 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.339% when pulling a846ecbcdc24bbf24328109ff9184645d1f3ba30 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.339% when pulling fcd8a1e09e68bafd09031571598cff065eb615b5 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+2.6%) to 85.339% when pulling 6ea1ac84c37fade2c4a116619d5c45692c4fe12a on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[hachreak]

ping @lnielsen (see the second commit for latest changes)

[coveralls]

Coverage increased (+3.3%) to 86.043% when pulling 1b5a6b3adb00c0733d4abb13d96db5e06b739ffb on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9f0bafdb36b57a75e2f26269d205a26d12 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.024% when pulling 4364fc9f0bafdb36b57a75e2f26269d205a26d12 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.024% when pulling 2dc7cd0334d5e617cb34a97572f27f73d1da14f8 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.043% when pulling 4f3781e094bfb183a9fb7614331d4fda3bc0a9e9 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.043% when pulling 5a43bf0fcca101aff9f7cc0fa8ef78ee1de90393 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.043% when pulling 1d2a0ab183bf6ee9238726f7e376e81bdcb5832f on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[coveralls]

Coverage increased (+3.3%) to 86.043% when pulling 43ee9553129228eeed9981b96911bc69653924f0 on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[lnielsen]

@hachreak Can you take a look why the tests are not passing.

[hachreak]

ok, I'll take a look

[coveralls]

Coverage increased (+3.3%) to 85.986% when pulling 62b1ca6b0aee2314f642fb8161685d5b56f8c13a on hachreak:fix_github into 3f7f0899e3cc8e40ab5a832177adbb6159bdef9e on inveniosoftware:master.

[hachreak]

ping @lnielsen