contrib: minor CERN plugin fix - Githubissues

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.

https://invenio-oauthclient.readthedocs.io

MIT License

6 stars 76 forks source link

contrib: minor CERN plugin fix #64

Closed omelkonian closed 8 years ago

omelkonian commented 8 years ago

Fixes an issue where g.identity.provides was populated with only the Cern groups. As access rights can be assigned to single users(i.e. emails), the user's e-mail must also be included in the g.identity.provides.

coveralls commented 8 years ago

Coverage increased (+0.02%) to 85.314% when pulling c017c59fded7ea41ad96ad9a09b32ed5a37f8394 on omelkonian:master into a1779d85d05824c1814e42baf1724e3cdebbd672 on inveniosoftware:master.

jirikuncar commented 8 years ago

@omelkonian please amend commit message (s/Cern/CERN/) and reformat the bullet points (kwalitee check message).

omelkonian commented 8 years ago

Although I cannot find any occurence of 'Cern'.

jirikuncar commented 8 years ago

@omelkonian look to the commit message ...

coveralls commented 8 years ago

Coverage increased (+0.02%) to 85.314% when pulling 6cb4c58f222925be4ca3dd6c8454fef648af399e on omelkonian:master into be2e97906d1a3bf5e69a7f2c42c89c31c731aa46 on inveniosoftware:master.

jirikuncar commented 8 years ago

@omelkonian please remove merge commit.

coveralls commented 8 years ago

Coverage increased (+0.02%) to 85.314% when pulling 4d8dd1743fb2f32a2bf449a3a7f0f3c0bd9d59ea on omelkonian:master into be2e97906d1a3bf5e69a7f2c42c89c31c731aa46 on inveniosoftware:master.

jirikuncar commented 8 years ago

@omelkonian I have checked the diff again and I see that you have replaced the quotes everywhere. It's ok, but it should be in separate commit. Also make sure that you write CERN and not Cern.

jirikuncar commented 8 years ago

WDYT about s/contrib: strings' formatting/global: quotes usage unification/?

jirikuncar commented 8 years ago

@omelkonian please use labels (FIX, NOTE) only when the message is important for readers of release notes. In the case of first commit you can remove the FIX label as it is just styling (* FIX Converts strings to be more uniform ...) and if you would really like to announce such change then label BETTER [1] is more appropriate.

[1] http://invenio.readthedocs.io/en/latest/technology/git.html#r2-remarks-on-commit-log-messages

egabancho commented 8 years ago

Besides @jirikuncar's comment LGTM

jirikuncar commented 8 years ago

@omelkonian please keep the branch up-to-date with the master branch and have a look to unresolved comments.