tests: coverage increase - Githubissues

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.

https://invenio-oauthclient.readthedocs.io

MIT License

6 stars 74 forks source link

tests: coverage increase #67

Closed omelkonian closed 8 years ago

omelkonian commented 8 years ago

Increases test coverage. (closes #59)

Signed-off-by: Orestis Melkonian melkon.or@gmail.com

jirikuncar commented 8 years ago

@omelkonian Good job❗ Can you please have a look at my last comments and let me know when you update the PR? Thanks

omelkonian commented 8 years ago

@jirikuncar LGTY?

jirikuncar commented 8 years ago

@omelkonian This branch is out-of-date with the base branch.

jirikuncar commented 8 years ago

@omelkonian please remove the merge commit. (git rebase -i upstream/master)

omelkonian commented 8 years ago

@jirikuncar i think its good to go

jirikuncar commented 8 years ago

@omelkonian see http://invenio.readthedocs.io/en/latest/technology/git.html#r2-remarks-on-commit-log-messages (tests: coverage increase)

jirikuncar commented 8 years ago

@omelkonian can you please rebase?

omelkonian commented 8 years ago

Is it ok that I replaced string quotes to more places than I changed?

jirikuncar commented 8 years ago

@omelkonian normally it would be better to do replacement in separate commit and then include your chances. Would you find a time to do it this way and then rebase your commit on top?

omelkonian commented 8 years ago

@jirikuncar I put it on a separate commit