search

inveniosoftware / invenio-oauthclient

Invenio module that provides OAuth web authorization support.
https://invenio-oauthclient.readthedocs.io
MIT License
6 stars 74 forks source link

contrib: automatic CERN groups updates #96

Closed jirikuncar closed 8 years ago

jirikuncar commented 8 years ago

Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch

ioannistsanaktsidis commented 8 years ago

@jirikuncar as #97 is merged, is there a way to also include this PR or to create a new release?

jirikuncar commented 8 years ago

@ioannistsanaktsidis this PR was ignored. I will rebase and do a new release straight away.

lnielsen commented 8 years ago

@jirikuncar We are on a extremely tight schedule right now and merging #97 was not to ignore this PR, just simply that we didn't have time for ping-pong. We have a long list of outstanding issues to do before Monday, and saving 10 minutes + waiting time here are important at this stage. Releases are cheap and easy to do so really don't see any problem in that this goes in a release couple of hours later.

ioannistsanaktsidis commented 8 years ago

@jirikuncar although the groups are added in the identity in your part, I just tested from the overlay side and identity.provides is empty.

jirikuncar commented 8 years ago

@ioannistsanaktsidis can you check if you are not overriding the identity with any identity_loaded or identity_changed signal handler?

ioannistsanaktsidis commented 8 years ago

@jirikuncar I think we should also add here https://github.com/jirikuncar/invenio-oauthclient/blob/840ec74a6553f4909db1c5cfda595a0da57ca781/invenio_oauthclient/contrib/cern.py#L279 this session[OAUTHCLIENT_CERN_SESSION_KEY] = set([]) in case someone wants to just disconnect his account. In that case the groups should not be available in the session.