inveniosoftware / invenio-pidstore

Invenio module that stores and registers persistent identifiers.
https://invenio-pidstore.readthedocs.io
MIT License
7 stars 38 forks source link

adds with_deleted flag #154

Closed zguillen closed 6 months ago

zguillen commented 7 months ago

:heart: Thank you for your contribution!

Description

Adds with_deleted flag in 'if pid.is_deleted()' block to allow downstream callers access to the deleted record via PIDDeletedError's record. I think this was originally intended but just missed.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
zguillen commented 7 months ago

Also, this is one of the necessary changes to support custom messages on tombstone pages (there appear to be many but might as well get this one off the list)