inveniosoftware / invenio-previewer

Invenio module for previewing files.
https://invenio-previewer.readthedocs.io
MIT License
5 stars 59 forks source link

txt-preview: improvments #180

Closed dfdan closed 1 year ago

dfdan commented 1 year ago

:heart: Thank you for your contribution!

Description

Fixes invenio-app-rdm#1864

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
dfdan commented 1 year ago

Thanks @fenekku, good thinking on the possible multi-byte errors. I've added some tests but it looks like test_macros.py fails all tests anyway :( Tom has demonstrated it works however.

It would be good if we could merge this and @tmorrell's #179 into a 1.3.10 release (as well as push these changes forwards into 1.4) - so there is a painless upgrade option for existing installs.

fenekku commented 1 year ago

Looping in Karolina from CERN. Once this one and Tom's one are merged let do a release and backport to 1.3.10 like Dan mentioned.