search

inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 87 forks source link

csl serialization: funders in citations #1069

Closed tmorrell closed 7 months ago

tmorrell commented 2 years ago

Package version (if known): v9.1

Describe the bug

Currently the CSL serialization adds the first (not all) funder as a note:

https://github.com/inveniosoftware/invenio-rdm-records/blob/ab138c16bc7f824220227dca7bbf95dc66d16cb3/invenio_rdm_records/resources/serializers/csl/schema.py#L131

This results in the funder appearing in citation styles that use the note field, like Chicago Annotated Bibliography.

Steps to Reproduce

  1. Enable chicago-annotated-bibliography as a citation style
  2. Go to a landing page and view citation
  3. See funding information in citation

Expected behavior

I think this entire note part of the serialization could be removed. It only seems partially implemented and I'm not sure why funding is needed in a CSL file.

Screenshots

Screen Shot 2022-09-20 at 2 19 33 PM

Additional context

github-actions[bot] commented 2 years ago

This issue was automatically marked as stale.