inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 87 forks source link

consistent service registration #1127

Open ppanero opened 2 years ago

ppanero commented 2 years ago

Services (and indexers) are registered in views.py. However, the name given as service_id parameter might not match the one of the service. This can lead to issues where e.g. passing the service.id to a task that will then not find the service in the registry since it was registered under a different name.

Does it makes sense to drop the service_id parameter? (Crosscheck this since it was added to support update propagation). Alternatively, change the registration to actually not pass a custom service_id.

github-actions[bot] commented 1 year ago

This issue was automatically marked as stale.