search

inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 84 forks source link

Validate Publisher via DataCiteProvider #1137

Closed fenekku closed 1 year ago

fenekku commented 1 year ago

From telecon https://docs.google.com/document/d/1bKOmv8HMs_L_t-hHuBN_cRpUeOthtMDSmAJOg4ASYrI discussion and discussion with @lnielsen :

When an instance enables DOI minting, the "Publisher" field will be required/validated by the provider. Otherwise, it won't.

We will validate the Publisher field via the DataCiteProvider::validate (used here https://github.com/inveniosoftware/invenio-rdm-records/blob/master/invenio_rdm_records/services/pids/manager.py#L57). This will require an interface change for the validate method but should be minimal to change since not a lot of Providers are around (use Python ABC to flag this immediately).

We can perhaps sneak in a clause for private record check here.

fenekku commented 1 year ago

I will get this in our (Northwestern's) December Sprint.