inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 81 forks source link

New version button disabled: add UI feedback #1675

Closed ptamarit closed 4 months ago

ptamarit commented 4 months ago

Closes https://github.com/zenodo/ops/issues/336

:heart: Thank you for your contribution!

Description

new-version

Extra changes:

  1. Centered the tooltip instead of the default left positioning.

new-version-centered

  1. Reworded the tooltip to explain more in details the reason for the new versions to be disabled (as suggested in https://github.com/zenodo/ops/issues/336)

new-version-centered-reword

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
ptamarit commented 4 months ago

In the past, I remember we had issues with tooltips over disabled elements. Can you make sure it works in all browsers?

Tested on:

Tooltips over disabled elements are also not super great for mobile (much better a "i" info icon), but I guess that we can live with that...

I agree.