Open tmorrell opened 3 months ago
@tmorrell Can you bring it up in the next telecon? In principle I don't see issues with adding the fields. It might have some impact on the serializers to use the new fields (e.g. book edition in citation formats) but better let people agree on first if they want the fields.
@tmorrell thank you for this change. As briefly mentioned during our last discussion, we will also need to have the following fields:
Date of submission to the university
Thesis Defence Date
Do you think these are fields that can be added to the default implementation, as many might need the same? Or they are too specific and we should go for new custom fields instead?
We will definitely need Thesis Defense Date
soon, but I'm not sure how best to implement it since I don't think there is custom field dates js widget. We basically need https://github.com/inveniosoftware/invenio-rdm-records/blob/12576835186dc837df7cdf20d905452eeab8291e/invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/fields/PublicationDateField/PublicationDateField.js, but I'm not sure how to get that working within custom fields.
So if you've got some suggestions how to implement it, I think they would be good additions to the default.
This PR was automatically marked as stale.
:heart: Thank you for your contribution!
Description
This PR adds new fields to the imprint and thesis sections.
This is a breaking change for thesis, since the thesis field was structured differently from the other publication custom fields and wasn't set up to support additional subfields. This change makes the thesis field consistent with the others, but will require current v12 users of this field to do an upgrade. I'm not sure what's needed to support that or if folks will think it's worth it.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: