inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 83 forks source link

Fix pid required feature #1765

Closed tmorrell closed 1 week ago

tmorrell commented 1 week ago

:heart: Thank you for your contribution!

Description

The fix for the parent doi configuration https://github.com/inveniosoftware/invenio-rdm-records/pull/1740 broke the "required" parameter for the pid provider. Previously you could have a pid provider that was active (shows up in the deposit form), but not required (pid would only be minted if something was entered). Because the check for "required" was removed, this stopped working. A test is also included.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
tmorrell commented 1 week ago

Thanks for the cleanup @utnapischtim I just rebased so this should be good to merge once CI finishes