inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 84 forks source link

Potential simplification of additional titles/descriptions #24

Closed fenekku closed 4 years ago

fenekku commented 4 years ago

We could potentially collapse additional_descriptions and additional_titles fields into a descriptions and titles fields resp. if we build an indexing hook (or other means) to allow description=mySearchTerm and title=mySearchTerm to still be valid search box searches.

tmorrell commented 4 years ago

Sounds like a good plan for a future improvement. It would make the metadata easier to understand and make the deposit form simpler.

ppanero commented 4 years ago

The main issue behind the two fields is developer/UI experience. If you have 10 titles? How do you know which one to display? we would also need to perform many many extra loops... IMHO this simplifies things a lot. What do you think?

fenekku commented 4 years ago

The first description and title in the array should be the main one (with the caveat of the type). Others would be placed according to types. This will take additional logic for sure.

tmorrell commented 4 years ago

We might want to tread title and description differently. I agree that the UI for multiple titles is tricky, and we don't use them. We use multiple descriptions for a lot of our records. They just get listed in the order they are in the metadata, similar to how authors are treated.

saragon02 commented 4 years ago

Alternative titles I believe are not as common as multiple descriptions of various types. I like the idea of the first title in an array serving as the main title, with the others serving as alternative titles. The type can be "alternative" unless more specific type designations are warranted.

lnielsen commented 4 years ago

A couple of points:

Above is based on experience with MARC21 in Invenio v1, and putting it all together has a huge impact on the code architecture, so I'd like to say with the current design of a primary title and primary description (and a list of additional).

Again, this is the internal storage formats and it doesn't change what RDM will expose via APIs or what RDM is capable of storing.

fenekku commented 4 years ago

I defer to that experience. I am fine with staying with the split between title and additional_titles. Let's close this by end of day if no one else feels strongly about keeping it.

fenekku commented 4 years ago

We will keep as is because it turns out to be fine. Closing!