search

inveniosoftware / invenio-rdm-records

DataCite-based data model for InvenioRDM flavour.
https://invenio-rdm-records.readthedocs.io
MIT License
15 stars 87 forks source link

serialization: should use minor version of datacite kernel #642

Open ppanero opened 3 years ago

ppanero commented 3 years ago

Datacite Export in landing page: schema version shows kernel-4, should we change to kernel-4.y

tmorrell commented 3 years ago

DataCite uses kernel-4 for all the 4 version json flavors because that matches how they do the XML validation (https://github.com/datacite/schema/blob/master/source/json/kernel-4.3/datacite_4.3_schema.json). I think using kernel-4.y makes more sense, and I've confirmed that the DataCite JSON API will accept the point version in the schema field. This means there will be some drift between the DataCite examples and the ones invenio uses...but we have that a bit already.

To correctly make this change, in addition to the RDM stuff the jsonschema in https://github.com/inveniosoftware/datacite/blob/master/datacite/schemas/datacite-v4.3.json should be changed. There might need to be a new rule added so the XML format behaves; this should just be checked after the schema is updated.

I'm focusing on other DataCite serialization issues first, but I can get to this afterwards if no one else picks this up.

github-actions[bot] commented 3 years ago

This issue was automatically marked as stale.