inveniosoftware / invenio-records-js

Invenio-Records client library for building the web UI.
https://invenio-records-js.readthedocs.io
GNU General Public License v2.0
1 stars 14 forks source link

relax contraint on angular version? #34

Open ltalirz opened 6 years ago

ltalirz commented 6 years ago

We are getting errors like Uncaught TypeError: angular.module(...).provider(...).info is not a function in the JS console when trying to deposit a new entry with the invenio-deposit module.

We are JS newbies, but it seems like these kind of errors tend to be related to a clash of angular versions (?).

In the invenio installation using docker, I get:

(invenio) invenio@e9abe65c8f15:~/.virtualenvs/invenio/var/instance/static$ npm list | grep -A 10 angular
├── angular@1.4.14
...
├─┬ invenio-records-js@0.0.8
│ ├── angular@1.4.8
...
├─┬ invenio-search-js@1.4.0
│ ├── angular@1.4.8

This is because the angular version is completely fixed here: https://github.com/inveniosoftware/invenio-records-js/blob/147bfa3795595984c254927321c89df22b454d30/package.json#L14-L16

Note: this This also concerns invenio-search-js