global: fix build - Githubissues

inveniosoftware / invenio-records-rest

Invenio records REST API module.

https://invenio-records-rest.readthedocs.io

MIT License

4 stars 62 forks source link

global: fix build #186

Closed jacquerie closed 6 years ago

jacquerie commented 6 years ago

Our build appears to be failing because of an incompatibility between invenio-records-rest and the latest beta release of marshmallow. See: https://travis-ci.org/inspirehep/inspire-docker/jobs/337193978#L7402.

I'm already seeing this failure locally on just invenio-records-rest, let's see if Travis agrees with me...

jacquerie commented 6 years ago

let's see if Travis agrees with me...

It doesn't. I guess the problem is that we install dependencies with --pre, so we pick marshmallow==3.0.0b7 instead of marshmallow==2.15.0. Therefore the pin should be on our side.

That said, I think we still need 1a18e0c18e070715c9c11c7a4a98e545c4ebc058 as I believe this build is anyway broken...

dfdan commented 6 years ago

a little late, but for info mashmallow==3.0.0b4 works fine for me - 3.0.0b7 which I pulled in today caused errors. I guess if it works with 2.15 that's more stable, but this might help pin down where the problem has snuck in...