search

inveniosoftware / invenio-records-rest

Invenio records REST API module.
https://invenio-records-rest.readthedocs.io
MIT License
4 stars 63 forks source link

CSV serialize #260

Closed vlad-bm closed 5 years ago

vlad-bm commented 5 years ago

Adding class for serializing records into CSV format.

ntarocco commented 5 years ago

Good job! 👍 Please have a look to Travis too that is failing!

ntarocco commented 5 years ago

@vladbmihaescu @egabancho @slint optimized the code with in memory buffer for the CSV output and return a generator. It should be more efficient with large amount of results. Added tests. I have tested with a REST client and it looks working fine.

lnielsen commented 5 years ago

Please also add tests with unicode characters (this is usually how I break the Python csv module) and check the import into e.g. Excel or other spreadsheet to ensure it loads nicely by default.

lnielsen commented 5 years ago

Btw, please also ensure you add it to the documentation: https://github.com/inveniosoftware/invenio-records-rest/blob/master/docs/api.rst

ntarocco commented 5 years ago

Please also add tests with unicode characters (this is usually how I break the Python csv module) and check the import into e.g. Excel or other spreadsheet to ensure it loads nicely by default.

actually my fault about this, I asked him to do it previously, he did it and then I pushed again removing that by mistake :) @vladbmihaescu sorry!