inveniosoftware / invenio-records-rest

Invenio records REST API module.
https://invenio-records-rest.readthedocs.io
MIT License
4 stars 62 forks source link

bug: wrong variable used #332

Closed carlinmack closed 5 months ago

carlinmack commented 7 months ago

:heart: Thank you for your contribution!

Description

Please describe briefly your pull request.

In all other tests with csv_excluded_fields and csv_included_fields, the comparison is made with the newly created new_key whereas here it is compared with parent_key and so this is most probably a bug

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
carlinmack commented 5 months ago

we were mistaken!