inveniosoftware / invenio-rest

REST API support for Invenio.
https://invenio-rest.readthedocs.io
MIT License
2 stars 41 forks source link

docs: point intersphinx to Flask 0.12 #90

Closed dinosk closed 6 years ago

dinosk commented 6 years ago

Closes https://github.com/inveniosoftware/invenio-rest/issues/89

Signed-off-by: Dinos Kousidis dinos.kousidis@cern.ch

dinosk commented 6 years ago

I remember hearing about this issue in the kickoff and I think I saw an email from @slint mentioning it, but I'm not 100% sure this was the proposed solution tbh

slint commented 6 years ago

(the comment you're referring to). That's the fix but I guess addressing the Flask version update is out of the scope of this sprint. (cc @lnielsen)

tiborsimko commented 6 years ago

Yeah, increasing Flask version is probably out of the scope of this sprint. If we promise to support Flask 0.11 in setup.py, then it might indeed look a bit inconsistent to point to 0.12 in the docs... However 0.11 docs are gone... so this PR may be an acceptable thing to do for now.

tiborsimko commented 6 years ago

(FWIW I noticed invenio-deposit uses the same, so I made a quick PR there too, not to forget... The other Invenio packages are OK.)