inveniosoftware / invenio-s3

S3 file storage support for Invenio.
https://invenio-s3.readthedocs.io
MIT License
0 stars 16 forks source link

Made region name configurable too #5

Closed wgresshoff closed 4 years ago

wgresshoff commented 5 years ago

Sorry, this was a copy/paste problem I did overlook.

Am 19.08.19 um 11:37 schrieb Esteban J. G. Gabancho:

@egabancho commented on this pull request.


In invenio_s3/config.py https://github.com/inveniosoftware/invenio-s3/pull/5#discussion_r315121085:

@@ -19,6 +19,17 @@ https://boto3.readthedocs.io/en/latest/reference/core/session.html#boto3.session.Session.client`_. """

+S3_REGION_NAME = None +"""S3 region name + +This is entirely optional, and if not provided, the region name will be +automatically set to 'us-east-1'. + +If set to a value (including the "http/https" scheme) it will be passed as

I am not sure what you mean by |(including the "http/https" scheme)|?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/inveniosoftware/invenio-s3/pull/5?email_source=notifications&email_token=AEDHD7R42T76MGAUCKOFAPLQFJSV5A5CNFSM4IIQRYW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCB5DLGA#pullrequestreview-276444568, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDHD7VYJ5UEWJBRPLXCW3DQFJSV5ANCNFSM4IIQRYWQ.

-- Universitäts- und Landesbibliothek Münster Krummer Timpen 3 D-48143 Münster

Tel.: +49 (0)251-8325510 Mail: gressho@uni-muenster.de

egabancho commented 4 years ago

Merged via 73fb93a0692c9dcf75626a4372cf2c6a3335e4df 😉