search

inveniosoftware / invenio-theme

Invenio standard theme.
https://invenio-theme.readthedocs.io
MIT License
7 stars 53 forks source link

Revert "global: remove breadcrumbs" #384

Closed jrcastro2 closed 3 months ago

jrcastro2 commented 3 months ago

This reverts commit 1cec8367f2b96dcfee3341a18630cee805ca03be.

Flask-breadcrumbs is still being used all around invenio, see: https://github.com/search?q=org%3Ainveniosoftware+flask_breadcrumbs&type=code

utnapischtim commented 3 months ago

Why it should be reverted?

utnapischtim commented 3 months ago

it will be removed in the next PR's. those package you mention have pinned invenio-theme to <3.0.0.

jrcastro2 commented 3 months ago

Why it should be reverted?

Flask-breadcrubms is still being used al around invenio, see here: https://github.com/search?q=org%3Ainveniosoftware+flask_breadcrumbs&type=code

Some repos started to fail due to this, f.e. https://github.com/inveniosoftware/invenio-files-rest or https://github.com/inveniosoftware/invenio-oauthclient/pull/324

Just wondering why it was decided to remove it from invenio-theme? I might be missing something

jrcastro2 commented 3 months ago

Discussed IRL with @utnapischtim, not needed as we will remove flask-breadcrumbs from all other repositories.