search

inveniosoftware / invenio-vocabularies

Invenio module for managing vocabularies.
https://invenio-vocabularies.readthedocs.io
MIT License
2 stars 40 forks source link

Error-message for importing funders-vocabulary are too vague #219

Open chriz-uniba opened 1 year ago

chriz-uniba commented 1 year ago

Package version (if known): invenio-app-rdm 9.1.3; invenio-vocabularies 0.11.6

Describe the bug

When importing a funders vocabulary from a zip-file the error-messages are too vague.

Steps to Reproduce

curl https://zenodo.org/api/files/25d4f93f-6854-4dd4-9954-173197e7fad7/v1.1-2022-06-16-ror-data.zip -o funders.zip
# invenio vocabularies import --vocabulary funders --origin funders.zip

FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
FundersServiceWriter: [{'ValidationError': {'identifiers': {0: {'identifier': 'Invalid ISNI identifier.'}}}}]
Vocabulary funders imported. Total items 102742.
102738 items succeeded
4 contained errors
0 were filtered.

Expected behavior

Getting a more detailed information of the ISNIs that were wrong.

Additional thought

Maybe related: error messages wrt. the names.yaml weren't better https://github.com/inveniosoftware/invenio-vocabularies/issues/215