inveniosoftware / invenio-vocabularies

Invenio module for managing vocabularies.
https://invenio-vocabularies.readthedocs.io
MIT License
2 stars 40 forks source link

funders:update to ROR v2 #317

Closed tmorrell closed 1 month ago

tmorrell commented 1 month ago

:heart: Thank you for your contribution!

Description

The PR switches the funders vocabulary to use the v2 version of the ROR schema https://github.com/inveniosoftware/invenio-vocabularies/issues/316.

It adds new fields:

For compatibility purposes we only include the first location and acronym. There doesn't seem to be many RORs with multiple locations or acronyms. Ideally we'd be able to include all of these, but it would require a breaking change which doesn't seem to be worth it.

It no longer assumes that the primary name is in english (which isn't correct). This will result in many more title fields that don't have english values, since ROR doesn't currently have complete labeling of the languages of names.

I'll moves the transformer to a central location so it can also be used for affiliations and handle withdrawn records in future PRs.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.