funders: fix: ROR v2 label names with lang None

[ptamarit]

:heart: Thank you for your contribution!

Description

• Fixes #339

  How to reproduce the problem:

  1. Download the latest ROR Data Dump (version v1.47 at the time of writing).
  2. Run the following command:

     $ invenio vocabularies import -v funders -o v1.47-2024-05-30-ror-data.zip | grep ValidationError
     FundersServiceWriter: [{'ValidationError': {'title': defaultdict(<class 'dict'>, {None: {'key': ['Field may not be null.']}})}}]
     FundersServiceWriter: [{'ValidationError': {'title': defaultdict(<class 'dict'>, {None: {'key': ['Field may not be null.']}})}}]
     FundersServiceWriter: [{'ValidationError': {'title': defaultdict(<class 'dict'>, {None: {'key': ['Field may not be null.']}})}}]
     ...

• The fix being a bit counter-intuitive, all the explanations are directly in the code comments.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• [x] I'm aware of the code of conduct.
• [x] I've created logical separate commits and followed the commit message format.
• [x] I've added relevant test cases.
• [x] I've added relevant documentation.
• [x] I've marked translation strings.
• [x] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• [x] I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• [x] I've followed the CSS/JS and React guidelines.
• [x] I've followed the web accessibility guidelines.
• [x] I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[ptamarit]

Yup, I fixed it in https://github.com/inveniosoftware/invenio-vocabularies/pull/327/files#top but this is good.

Thanks for having a look! Sorry, I was testing what was already merged, and totally missed the fix in the affiliations PR.

After seeing your fix, I actually replaced:

lang = lang if lang is not None else "en"

by:

if lang is None:
    lang = "en"

Two lines, but clearer. :)