The 1st commit includes the country_name in the API response for funders which have a country_name (recently updated ones)
The pull request inveniosoftware/invenio-app-rdm#2704 modifies deserializeFunder to pass include country_name in the deserialized form of funder items.
The 2nd commit simplifies the logic of deserializeFunderToDropdown by using optional chaining
The 3rd commit modifies deserializeFunderToDropdown to shows the country code for existing funders which don't have yet a country_name
Note that the modified deserializeFunder function is used lower down in the render function of CustomAwardForm.
:shrug: Open questions
Places which might need to be modified to also include country_name:
:heart: Thank you for your contribution!
Description
:walking: Review path
deserializeFunder
to pass include country_name in the deserialized form of funder items.deserializeFunderToDropdown
by using optional chainingdeserializeFunderToDropdown
to shows the country code for existing funders which don't have yet a country_namedeserializeFunder
function is used lower down in therender
function ofCustomAwardForm
.:shrug: Open questions
Places which might need to be modified to also include country_name:
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: