inveniosoftware / invenio

Invenio digital library framework
https://invenio.readthedocs.io
MIT License
620 stars 291 forks source link

RFC WebComment in Invenio 2 #2957

Closed egabancho closed 8 years ago

egabancho commented 9 years ago

WebComment is the legacy commenting engine which allow users to add comments to records in the form of a discussion.

The current main features are:

It would be nice if the new implementation is more flexible allowing comments to be connected to a document (or anything) directly.

One possible solution would be to build an extension that uses any of the existing commenting engines like isso(written in python) or Disqus.

But I think we should also allow custom implementations as some of the functionalities we are using right now are quite hard to find.

cc @kasioumis

kaplun commented 9 years ago

:+1: for outsourcing commenting to an external framework, such as the proposed Isso. Comments are not the core business of Invenio and we are going therefore to be better served by some third-party modern framework.

I have given a brief look at Isso and indeed looks promising. We should evaluate pros and cons though. Disqus is :-1: (unless someone wants to really integrate it in is own overlay) because it's not a framework/tool but an external service.

tiborsimko commented 9 years ago

Disqus

For sites hosting confidential material, it may not be possible to use cloud-based solutions.

Isso

This would be more interesting possibility. Have you done extensive feature comparison? Also, what about per-page, per-equation, etc annotations? We may want to tackle the future of these two facilities together.

kaplun commented 9 years ago

Isso seems currently pretty basic. Doesn't seem to support authentication. On the other hand allows to attach commenting everywhere (identifying the anchors with a URI). Then one can programmatically query it to discover new comments in case of indexing.

However the fact that has no integrated authentication seems a very weak point.

egabancho commented 9 years ago

Have you done extensive feature comparison?

We, @kasioumis and I, did a quick comparison an we found a few weaknesses on Isso.

As @kaplun pointed out the user authentication is the most visible one.

We also think storing CDS comments on SQLittle is not the best solution, they claim that comments are not big data and they put this example:

For example, 209 threads and 778 comments in total only need 620K (kilobyte) memory. Excellent use case for SQLite.

In a normal week we usually get around 500 comments on CDS.

switowski commented 9 years ago

Subscription to a comment

We actually have a user asking for that (RQF0475329) and it makes sense to have two levels of subscription:

egabancho commented 8 years ago

Moved to https://github.com/inveniosoftware/invenio-comments/issues/13