Changer checklist - Githubissues

inveniosoftware / license-changer

Scripts for automating license change for Invenio.

Other

1 stars 6 forks source link

Changer checklist #1

Open krzysztof opened 6 years ago

krzysztof commented 6 years ago

Checklist for license changer QA:

git grep -i "GPL"
git grep -i "pypy"
Non-Invenio packages (e.g. "dcxml"), should not have "Invenio" in the license headers and probably nowhere in the code anywhere: git grep -i Invenio
Review the list of authors in AUTHORS.rst. Should be no duplicate names.
Check if README.rst has updated version tag badge and that the Image (shield.io) and the URL resolve to PyPy package repo
All commits should be made by "Invenio <info@inveniosoftware.org>"

switowski commented 6 years ago

[ ] AUTHORS.rst:
- [ ] Check if the list of contributors in was changed (No duplicates? No weird names?)
- [ ] Check if there is license on top of the file
[ ] Check if .travis.yml has:
- [ ] allow_failures specifying tests that are using env: REQUIREMENTS=devel ...
- [ ] username for pypi: inveniosoftware
- [ ] changed password for pypi

krzysztof commented 6 years ago

Repositories which require manual version bump:

dcxml
citeproc-py-style
invenio-search-js

EDIT: (DONE)

krzysztof commented 6 years ago

We need to check which other repositories will have to have those versions bumped in the dependencies

@slint already mentioned: invenio-search-js is a dependency of invenio-records-ui via it's asset bundle... dcxml of invenio-record-rest[dublincore]

krzysztof commented 6 years ago

Invenio-search needs to have changes.rst updated

krzysztof commented 6 years ago

First batch to review:

[x] https://github.com/inveniosoftware/invenio-assets/pull/79
[x] https://github.com/inveniosoftware/dcxml/pull/9 [@switowski]
[ ] https://github.com/inveniosoftware/invenio-search-js/pull/119 [@switowski] (no release due to NPM issues)
[x] https://github.com/inveniosoftware/invenio-cache/pull/6
[x] https://github.com/inveniosoftware/invenio-config/pull/35
[x] https://github.com/inveniosoftware/invenio-celery/pull/52
[x] https://github.com/inveniosoftware/invenio-i18n/pull/68 (invenio-assets dependecy)
[x] https://github.com/inveniosoftware/invenio-db/pull/107
[ ] https://github.com/inveniosoftware/invenio-search/pull/135 (dependecies)
[x] https://github.com/inveniosoftware/invenio-mail/pull/41
[x] https://github.com/inveniosoftware/invenio-formatter/pull/57
[x] https://github.com/inveniosoftware/invenio-logging/pull/39
[x] https://github.com/inveniosoftware/invenio-rest/pull/88
[x] https://github.com/inveniosoftware/citeproc-py-styles/pull/8

krzysztof commented 6 years ago

Second batch:

lnielsen commented 6 years ago

Third batch:

krzysztof commented 6 years ago

Fourth batch:

[x] https://github.com/inveniosoftware/invenio-access/pull/148 (waiting for invenio-accounts PyPI release)

lnielsen commented 6 years ago

5th batch:

[x] https://github.com/inveniosoftware/invenio-admin/pull/63

6th batch:

7th batch:

8th batch:

9th batch:

10th batch:

[x] https://github.com/inveniosoftware/invenio-records-rest/pull/198

11th batch:

[x] https://github.com/inveniosoftware/invenio-marc21/pull/63

12th batch:

[x] https://github.com/inveniosoftware/invenio-oaiserver/pull/148