inveniosoftware / react-invenio-app-ils

Single Page App built with React for InvenioILS.
https://react-invenio-app-ils.readthedocs.io
MIT License
5 stars 19 forks source link

[MERGE WITH Backend] New literature request form and fixes #360

Closed ntarocco closed 3 years ago

ntarocco commented 3 years ago

WARNING To be merged with backend https://github.com/inveniosoftware/invenio-app-ils/pull/1034

Screenshot 2021-02-14 at 17 48 40 Screenshot 2021-02-14 at 17 49 03 Screenshot 2021-02-14 at 17 47 28
ntarocco commented 3 years ago

It would be nice if the literature request details were inside a container (like in document details) instead of fully expanding to the sides of the screen. Also since document pid is not required in the form maybe it should have an empty option in case we want to remove it.

Makes sense for the container! Is it ok if I do it in the next one since I will have to work on the layout?

For the document pid, it is already the case, just not very visible, that's why Javier was suggesting to add - instead. I was actually thinking to remove from the form the document_pid field since it can be changed from the details page...