inveniosoftware / react-invenio-app-ils

Single Page App built with React for InvenioILS.
https://react-invenio-app-ils.readthedocs.io
MIT License
5 stars 19 forks source link

[Merge with IAILS#1064] Replace Document form with RJSF and various fixes #403

Closed ntarocco closed 3 years ago

ntarocco commented 3 years ago
ntarocco commented 3 years ago

In case of too many authors:

Screenshot 2021-03-12 at 18 14 57

ntarocco commented 3 years ago

LGTM, the only comment I have is that in some cases e.g.:

Screenshot 2021-03-15 at 16 06 56

the buttons Add Item are very close to each other and it is not very clear to which field they are referring to. Is it possible to change the text to something like Add author? Or maybe to move the button next to the title of the field?

wow, thank you for checking it out and checking!!! 👍🏼 Unfortunately not much possible. I was hoping that with the release of RJSF 2.5.0 we could finall override the Array template (see my PR here) but they did a mistake publishing on NPM and we cannot override yet. As soon as they do, we can override the template probably and do something...

I think the best we can not now is to avoid to have array fields as last field inside another array field, but to have a text for example instead.